Code review, Team 19 – Mermaid River
|
Hello Team 19! First of all looking at your commit-history at bitbucket, you do not seem to be very active at all with your game… Moving on to your player class, I assume that to be the one called PlayerEntity, first of all it is completely without comments, that is a bad coding habit. Comments on what your functions do makes code much easier to read and navigate. Secondly you have a bunch of pointers to different managers in your .h file, half of these pointers you don’t even use in the .cpp, why are there stuff in your .h file that you never use? Thirdly, forward declaration… Why didn’t you just include the .h files for the classes you use in your player class? As it is now you forward declare those in PlayerEntity.h and then include them in PlayerEntity.cpp, which wouldn’t be necessary if you would have just included them in PlayerEntity.h. Fourth, all those pointers you have. Seeing as the pointers to your managers needs to be used in a lot of places in your game, a tip would be to collect them all in a system class or something similar. Fifth, what is going on with your collision? You have a collisionmanager, a base_collider and a collider_box that I don’t understand how you are attempting to use. Sixth, your inputmanager is used in your players update function, but you never declare it! This will make your game crash! Seventh, seeing as the code you have on Bitbucket doesn’t even run this must be old and unused code from before your alpha, I tried your game at the playtest on feb-29:th, and there you at least had a player that you could control and code that ran, this is not that code.  |