Code Review for Team 19 – Mermaid River
|
Hello team 19, I have been going through your player class and trying to figure everything out, so here is some my conclusion and some tips. First it seems you don’t really use source tree to its full potential, currently now as this post is being written the last update on your repositories was 4 days ago and the one before that was a week ago. I would firstly recommend you to actually use source tree and commit your code to it. It makes it way easier for you guys to work together but also for others to check out how it’s going. When trying to find out how the player class works I first tried to run the game, however it seems your game doesn’t even work, I first had to include some external library’s myself, however after getting it to run it seems the game isn’t even in the alpha state as you can’t even start a basic level. It clearly seems this isn’t the version you have been showing as that one actually has a character you can use, this one doesn’t. Anyway, I tried to look into the player class as instructed by Tommi to check out how it works and give some advice, seeing as I could try to find something out about it at least seeing as the game didn’t even work. First thing to note is that you include a bunch of different pointers that you don’t really use or set somewhere, in the updated function you use the pointer “m_pInputManager” However you don’t set it anywhere, because of this it will just crash when you try to use it. Another thing is that you have firstly an “CollisionManager” pointer that you don’t really use, you also have an “Base_Collider “and thirdly you have an “Box_collider”, that’s 3 different colliders that don’t seem to work and you don’t even seems to use them too anything, so my first advice would try to figure out how you actually want your collision to work. You are also currently having a vector2f for speed; I would recommend having the y and x speed the same; however that’s just a preference that I prefer. Other than that I would recommend you to put most of the different pointers into a system.h that store all the pointers. (You currently have 4 different pointers that you will be including in most of your places). I would also recommend for you guys that in the features to add some comments your code to make it easier to understand, currently it just seems too be filled with different pointers and variables that are not really used and it just seems to be filled with code that don’t even work. I’m not sure what to make out of this too be honest. Best regards Pontus Berglund  |
