Browsing 'Programming': Posts from Game Design and Programming
Code review of Mermaid River
In the game Mermaid River the class called “Captain” is represented as the playable avatar in the game. An object pointer of captain is stored as a private member in a derived class called “GameState”. When the game state’s “Enter” function is executed, the captain gets a struct filled with pointers to different objects like draw manager, state manager, mouse, etc. But all of the instances weren’t used like the state manager. They could have send only the useful modules […]
Code review of Mermaid River
In the game Mermaid River the class called “Captain” is represented as the playable avatar in the game. An object pointer of captain is stored as a private member in a derived class called “GameState”. When the game state’s “Enter” function is executed, the captain gets a struct filled with pointers to different objects like draw manager, state manager, mouse, etc. But all of the instances weren’t used like the state manager. They could have send only the useful modules […]
Code Review av grupps 1 spelar klass
Code Review av grupps 1 spelar klass
Första intryck
Först när jag fick hem spelet så började jag med att kolla på hur ni har byggt klassen. Mitt första intryck blev att jag tyckte att det var väldigt lite kod som ni har i klassen. Detta fick mig att undra om spelet faktiskt funkade men när jag försökte att köra spelet så möttes jag av felet att den inte kunde hitta exe filen i _binary mappen.
Jag menar i h filen så […]
Code Review av grupps 1 spelar klass
Code Review av grupps 1 spelar klass
Första intryck
Först när jag fick hem spelet så började jag med att kolla på hur ni har byggt klassen. Mitt första intryck blev att jag tyckte att det var väldigt lite kod som ni har i klassen. Detta fick mig att undra om spelet faktiskt funkade men när jag försökte att köra spelet så möttes jag av felet att den inte kunde hitta exe filen i _binary mappen.
Jag menar i h filen så […]
Code rewiev of group 5
Let me begin with saying that in my group we have a lot of coupling in our player class so when I looked through your player class I was amazed with how little coupling you have. You have some from SFML but other than that I have a hard time finding any. I don’t think I can give you any tip on how you can decouple your player class when you have a lot less coupling then we do. And there […]
Code rewiev of group 5
Let me begin with saying that in my group we have a lot of coupling in our player class so when I looked through your player class I was amazed with how little coupling you have. You have some from SFML but other than that I have a hard time finding any. I don’t think I can give you any tip on how you can decouple your player class when you have a lot less coupling then we do. And there […]
Owl Moms features
Dear, Group 13.
I can tell you are using Managers to handle events such as input manager, animation manager and sound manager and then use them all inside the owl mom class. Using managers is useful and increases efficiency by using the same code and over and over again.
You are creating the owl mom inside the enter function inside game state which is good since it need to be in the game from the start. The owl mom is connected with […]
Owl Moms features
Dear, Group 13.
I can tell you are using Managers to handle events such as input manager, animation manager and sound manager and then use them all inside the owl mom class. Using managers is useful and increases efficiency by using the same code and over and over again.
You are creating the owl mom inside the enter function inside game state which is good since it need to be in the game from the start. The owl mom is connected with […]
Vad som finns i Grupp12 kod som jag ser, Avataren Behöver för att fungera.
Spelarens sätt att ge input till Spelet, än så kallad Avatar.
Avataren är beroende av en Sprite med textur& GameState sätter in Avatarens Kanon på plats som är en egen Klass. som följer musen för att kunna låta spelaren skjuta. Men själva Avataren behöver inte ha en kanon klass. då själva Avataren Har ingen direktkoppling till kanon klassen Så om det fanns kod för att bytta Vapen skulle det nog fungera också men behövs ändras i GameState.
Avataren Kan bara flytta sig Framåt […]
Vad som finns i Grupp12 kod som jag ser, Avataren Behöver för att fungera.
Spelarens sätt att ge input till Spelet, än så kallad Avatar.
Avataren är beroende av en Sprite med textur& GameState sätter in Avatarens Kanon på plats som är en egen Klass. som följer musen för att kunna låta spelaren skjuta. Men själva Avataren behöver inte ha en kanon klass. då själva Avataren Har ingen direktkoppling till kanon klassen Så om det fanns kod för att bytta Vapen skulle det nog fungera också men behövs ändras i GameState.
Avataren Kan bara flytta sig Framåt […]
Code review group 15
Player klassen för Spelet Geneva lost är ganska minimal i dagsläget och jag kan inte kommentera direkt nåt större över dess funktionalitet med tanke på att ni har bara kod för rörelse.
I dagsläget hanteras all player logik i Gamestate i ert spel vilket kanske inte är optimalt och gör framtida ändringar och debugging onödigt komplicerad.
Bästa skulle ju varit om ni hade en klass för Player som har all logik för hur spelaren skall bete sig och röra sig med mera vilket […]
Code review group 15
Player klassen för Spelet Geneva lost är ganska minimal i dagsläget och jag kan inte kommentera direkt nåt större över dess funktionalitet med tanke på att ni har bara kod för rörelse.
I dagsläget hanteras all player logik i Gamestate i ert spel vilket kanske inte är optimalt och gör framtida ändringar och debugging onödigt komplicerad.
Bästa skulle ju varit om ni hade en klass för Player som har all logik för hur spelaren skall bete sig och röra sig med mera vilket […]
Code Review
This is a code review of Potato Pirates made by group 18. Most of the design changes I’m going to suggest that could have been made are things that could be good to keep in mind for future projects, but some of these might just add unnecessary workload to implement right now for their project, as it’s relatively near the end. Some of these changes would mean a bit more code that would be put in managers in the beginning, […]
Code Review
This is a code review of Potato Pirates made by group 18. Most of the design changes I’m going to suggest that could have been made are things that could be good to keep in mind for future projects, but some of these might just add unnecessary workload to implement right now for their project, as it’s relatively near the end. Some of these changes would mean a bit more code that would be put in managers in the beginning, […]
Code Review of team 18
First off I’d like to compliment the programmers of Team 18 for a thorough file distribution of their header and source files. It’s easy to navigate through the files for a person who sees the code for the first time.
Looking at the player class, I noticed that it has over 600 lines of code. Browsing through I noticed that several functions that are related to the player, like the powerups, are included in the player class. To me it seems that […]
Code Review of team 18
First off I’d like to compliment the programmers of Team 18 for a thorough file distribution of their header and source files. It’s easy to navigate through the files for a person who sees the code for the first time.
Looking at the player class, I noticed that it has over 600 lines of code. Browsing through I noticed that several functions that are related to the player, like the powerups, are included in the player class. To me it seems that […]
Code Review on Group 15’s game “Geneva Lost”
This is a code review on group 15’s project “Geneva Lost”. In this report I am going to look into how their player class is implemented in their game and the types of connections it has with other classes. Simply put; what makes the player do stuff.
Their player needs a few things to make it work:
It inherits from a base class called GameObject.
A Entity class which is derived from GameObject.
It also needs a DrawManager which renders the players texture onto […]
Code Review on Group 15’s game “Geneva Lost”
This is a code review on group 15’s project “Geneva Lost”. In this report I am going to look into how their player class is implemented in their game and the types of connections it has with other classes. Simply put; what makes the player do stuff.
Their player needs a few things to make it work:
It inherits from a base class called GameObject.
A Entity class which is derived from GameObject.
It also needs a DrawManager which renders the players texture onto […]
Code Review of team 5s Player
I have to say that i’m impressed with how simple the player class is and that it has pretty much no coupling other than the functions that are in SFML. Our player class has a lot of coupling going on which makes me even more amazed and i’ll have to take some note on how this is done. I don’t really don’t know if i can say anything more since it’s hard to recommend how to decouple something that already […]
Code Review of team 5s Player
I have to say that i’m impressed with how simple the player class is and that it has pretty much no coupling other than the functions that are in SFML. Our player class has a lot of coupling going on which makes me even more amazed and i’ll have to take some note on how this is done. I don’t really don’t know if i can say anything more since it’s hard to recommend how to decouple something that already […]
Code review, Team 19 – Mermaid River
Hello Team 19!
First of all looking at your commit-history at bitbucket, you do not seem to be very active at all with your game…
Moving on to your player class, I assume that to be the one called PlayerEntity, first of all it is completely without comments, that is a bad coding habit. Comments on what your functions do makes code much easier to read and navigate.
Secondly you have a bunch of pointers to different managers in your .h file, half […]
Code review, Team 19 – Mermaid River
Hello Team 19!
First of all looking at your commit-history at bitbucket, you do not seem to be very active at all with your game…
Moving on to your player class, I assume that to be the one called PlayerEntity, first of all it is completely without comments, that is a bad coding habit. Comments on what your functions do makes code much easier to read and navigate.
Secondly you have a bunch of pointers to different managers in your .h file, half […]
Code Review for Team 19 – Mermaid River
Hello team 19, I have been going through your player class and trying to figure everything out, so here is some my conclusion and some tips.
First it seems you don’t really use source tree to its full potential, currently now as this post is being written the last update on your repositories was 4 days ago and the one before that was a week ago. I would firstly recommend you to actually use source tree and commit your code to it. […]
Code Review for Team 19 – Mermaid River
Hello team 19, I have been going through your player class and trying to figure everything out, so here is some my conclusion and some tips.
First it seems you don’t really use source tree to its full potential, currently now as this post is being written the last update on your repositories was 4 days ago and the one before that was a week ago. I would firstly recommend you to actually use source tree and commit your code to it. […]