Analysis of group 7
|
To begin with the code was easy to understand even for someone that doesn’t have so much experience. When looking at the player class, it does not have any couplings except the stdafx.h file that contains some includes but other than that it’s no more. This makes it hard to give feedback on how to make it smaller. Instead I would divide all that does not entirely have much to do with the player class, like the clouds, potatoes and bullet impacts. The reason I would have chosen to do it this way is because it’s much easier to edit and debug the code if everything is divided into their own classes. In these classes they can have code that is only related to that object, i.e. draw and update themselves. This will also reduce the code inside the player class for easier navigation in the code. However this change might make it harder for beginners trying to understand which class is connected to what.  |